CM-67318: Warn when env vars override configured credentials#474
Merged
Conversation
cycode configure writes credentials to the file but CYCODE_CLIENT_ID/ CYCODE_CLIENT_SECRET (and the URL env vars) take precedence on every subsequent call. Previously the override notice was only appended to the success message when a value actually changed, so a stale env var could silently shadow freshly configured credentials with no indication. Split the override notice into its own helpers and print it as a warning whenever the relevant env vars are set, regardless of whether anything was updated. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
omerr-cycode
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cycode configurewrites credentials to~/.cycode/credentials.yaml, butCYCODE_CLIENT_ID/CYCODE_CLIENT_SECRET(and the API/APP URL env vars) take precedence on every subsequent call. The override notice was previously only appended to the success message when a value actually changed, so a stale env var could silently shadow freshly configured credentials with no warning.get_credentials_environment_variables_override_warning/get_urls_environment_variables_override_warning).configurenow prints these asWarning:lines whenever the relevant env vars are set — regardless of whether anything was updated (also covers the partial case where only the client id is set).tests/cli/commands/configure/test_messages.pycovering the new helpers.Jira
CM-67318
🤖 Generated with Claude Code